[wp-trac] [WordPress Trac] #52429: Combine/globalize the CSS/JS between Site Health & Privacy Settings
WordPress Trac
noreply at wordpress.org
Thu May 20 20:45:38 UTC 2021
#52429: Combine/globalize the CSS/JS between Site Health & Privacy Settings
-------------------------+---------------------------------------
Reporter: xkon | Owner: notlaura
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.8
Component: Site Health | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, css, privacy
-------------------------+---------------------------------------
Comment (by ryelle):
If we create a new file just for the shared CSS, then add it as a
dependency of `site-health` & `edit`, that should keep the expected styles
for plugins in both places, right? I don't know if it's worth creating
another new stylesheet just for the privacy styles, once you remove the
shared styles there's <100 lines of CSS left.
> The modifications also appear to have negated some styles used by the
Site Health dashboard widget, which were defined, and built upon, styles
from the site-health stylesheet.
It looks like this is from "Use flex for alignment in `.health-check-
title-section` vs. only text-align" - the flex is messing up the layout in
the widget. I think it would make more sense to use different classes
here, but I haven't thoroughly investigated it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52429#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list