[wp-trac] [WordPress Trac] #52429: Combine/globalize the CSS/JS between Site Health & Privacy Settings
WordPress Trac
noreply at wordpress.org
Thu May 20 12:28:50 UTC 2021
#52429: Combine/globalize the CSS/JS between Site Health & Privacy Settings
-------------------------+---------------------------------------
Reporter: xkon | Owner: notlaura
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.8
Component: Site Health | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, css, privacy
-------------------------+---------------------------------------
Comment (by Clorith):
I had a quick look at the proposed patch, I'm a but confused as to why
we're moving everything into a catch-all file of `edit.css` here? If I'm
not mistaken, the privacy things were only meant to be there temporarily
because it was introduced in a minor release where no new files should be
added, and it was meant to have its own stylesheet after this?
Is `edit.css` always enqueued on every page, I see
[https://wpdirectory.net/search/01F64TY6EFJHSBXW5036BCNVBP some plugins
are enqueueing `site-health` styles them selves], so we want to avoid
styles breaking for them as well if possible.
The modifications also appear to have negated some styles used by the Site
Health dashboard widget, which were defined, and built upon, styles from
the `site-health` stylesheet.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52429#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list