[wp-trac] [WordPress Trac] #53493: Errors in `ms-files.php` aren't logged

[WordPress Trac]

#53493: Errors in `ms-files.php` aren't logged
-------------------------+------------------------------
 Reporter:  iandunn      |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  low          |   Milestone:  Awaiting Review
Component:  Upload       |     Version:  3.0
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:  multisite
-------------------------+------------------------------

Comment (by iandunn):

 ticket:11742#comment:8 adds more context. Before `11742.2.diff`,
 `11742.diff` had taken this approach:

 > In order to be completely backwards compatible, I needed to create a new
 SHORTLOAD constant that is identical to SHORTINIT. This prevents an
 existing blogs.php drop-in that defines SHORTINIT from generating an
 unsuppressed E_NOTICE for redefining a constant.

 So when `error_reporting(0)` was added in `11742.2.diff`, the goal was
 really just to hide those specific notices.

 However, `12742.5.diff` intended it to hide all notices, similar to what
 the REST API, `admin-alax.php`, and XML-RPC do today:

 > Return `error_reporting(0)` to `ms-files.php`, reverting [13038]. Remove
 deprecated warnings as it breaks media file handling, and no translation
 support exists, reverting part of [12977].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53493#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform