[wp-trac] [WordPress Trac] #53493: Errors in `ms-files.php` aren't logged

[WordPress Trac]

#53493: Errors in `ms-files.php` aren't logged
-------------------------+-----------------------------
 Reporter:  iandunn      |      Owner:  (none)
     Type:  enhancement  |     Status:  new
 Priority:  low          |  Milestone:  Awaiting Review
Component:  Upload       |    Version:  3.0
 Severity:  normal       |   Keywords:
  Focuses:  multisite    |
-------------------------+-----------------------------
 r12936 added `error_reporting(0)` to `ms-files.php`. This makes
 troubleshooting problems like #53492 ''much'' harder.

 I haven't groked #11742 yet, but `11742.2.diff` describes the reason as:

 > Sets error_reporting to 0, removing requirement for a new SHORTLOAD
 constant and error suppression operators.

 My guess is that the goal is to prevent PHP notices/warnings from breaking
 the image output. That makes sense, but it could be accomplished with
 `ini_set( 'display_errors', 'off' )`, without hiding errors from logs.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53493>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform