[wp-trac] [WordPress Trac] #53432: Fatal error during update to 5.8 of a site with an active Gutenberg plugin (version less than 10.7)

WordPress Trac noreply at wordpress.org
Fri Jun 25 11:55:28 UTC 2021


#53432: Fatal error during update to 5.8 of a site with an active Gutenberg plugin
(version less than 10.7)
---------------------------------------+-----------------------------
 Reporter:  oglekler                   |       Owner:  hellofromTonya
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.8
Component:  Upgrade/Install            |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Thanks for the PR!

 Replying to [comment:16 peterwilsoncc]:

 > * Introduces a new option `wp_deactivated_plugins` to store details
 about plugins that have been deactivated
 > * Introduces a new function `wp_deactivated_plugins_notice` which
 displays notices about a plugin that has been disabled during the upgrade

 1. Could the function be named `deactivated_plugins_notice()` (without the
 `wp_` prefix), for consistency with `paused_plugins_notice()` and
 `paused_themes_notice()`?
 2. I think the option does not need the `wp_` prefix either, as none of
 the other core options have it, with `wp_page_for_privacy_policy` being a
 single exception.
 3. Should the option be added to `populate_options()` for new installs?

 > * Question: I've got an auto-loading option to avoid an additional db
 query on every admin screen but it adds a row to the options table that
 will be infrequently used. Is this the better approach or should WP just
 make the extra query?

 If I'm reading correctly, the option would be empty most of the time? In
 that case, I think it should not have a significant effect on memory
 footprint, and autoloading is probably fine.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53432#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list