[wp-trac] [WordPress Trac] #53562: Widgets Editor in Customizer doesn't load with E2E tests + 0ms Animations

WordPress Trac noreply at wordpress.org
Mon Jul 12 08:36:42 UTC 2021


#53562: Widgets Editor in Customizer doesn't load with E2E tests + 0ms Animations
----------------------------+----------------------------------------------
 Reporter:  mikeschroder    |       Owner:  mikeschroder
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  5.8.1
Component:  Editor          |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript, css, administration
  fixed-major               |
----------------------------+----------------------------------------------

Comment (by mikeschroder):

 Replying to [comment:9 kevin940726]:
 > I think this fix causes a regression that the focus is now lost when
 expanding/collapsing sections, while it should default to focusing on the
 back button (the first element). This is also the reason that e2e tests in
 gutenberg is now constantly failing.

 Will check into this along with @mamaduka.

 > I'm not sure I understand the code either. `el` is just a dummy `<div>`
 created for obtaining the normalized transition name. I don't think this
 is the correct place to fix it?
 >
 > I mentioned in the gutenberg issue that I think the fix should fall
 along the lines here: https://github.com/WordPress/wordpress-
 develop/blob/bdf7dd6299e4453f9d7438de0a0e138d950ec0bf/src/js/_enqueues/wp/customize/controls.js#L1294-L1305.
 It should fire `completeCallback` regardless of if there's a
 `transitionend` event or not. Or, we could just go with #53542 and drop
 this :)

 I made the change in the current location because it seems like it is
 where detection of whether transitions are supported or not is happening.
 Of course, if this is causing side effects, let's fix it elsewhere (or in
 addition).

 I think if we fix this, assuming I understand properly, then it still
 helps with an edge case for users that have CSS overrides, but agreed that
 #53542 would be great. I don't think I have the requisite core CSS
 knowledge to handle that one appropriately -- I'm hoping that someone who
 does will be able to help. Regardless, I agree it'd be great to have it
 fixed, and if we can use that method in the tests instead, that's
 excellent.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53562#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list