[wp-trac] [WordPress Trac] #53562: Widgets Editor in Customizer doesn't load with E2E tests + 0ms Animations
WordPress Trac
noreply at wordpress.org
Fri Jul 9 18:23:44 UTC 2021
#53562: Widgets Editor in Customizer doesn't load with E2E tests + 0ms Animations
----------------------------+----------------------------------------------
Reporter: mikeschroder | Owner: mikeschroder
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.8.1
Component: Editor | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, css, administration
fixed-major |
----------------------------+----------------------------------------------
Comment (by kevin940726):
I think this fix causes a regression that the focus is now lost when
expanding/collapsing sections, while it should default to focusing on the
back button (the first element). This is also the reason that e2e tests in
gutenberg is now constantly failing.
I'm not sure I understand the code either. `el` is just a dummy `<div>`
created for obtaining the normalized transition name. I don't think this
is the correct place to fix it?
I mentioned in the gutenberg issue that I think the fix should fall along
the lines here: https://github.com/WordPress/wordpress-
develop/blob/bdf7dd6299e4453f9d7438de0a0e138d950ec0bf/src/js/_enqueues/wp/customize/controls.js#L1294-L1305.
It should fire `completeCallback` regardless of if there's a
`transitionend` event or not. Or, we could just go with #53542 and drop
this :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53562#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list