[wp-trac] [WordPress Trac] #25473: wp_text_diff creates wrong number of columns if title arguments are set

WordPress Trac noreply at wordpress.org
Fri Jan 29 16:24:10 UTC 2021


#25473: wp_text_diff creates wrong number of columns if title arguments are set
---------------------------------------+----------------------------
 Reporter:  joedolson                  |       Owner:  joedolson
     Type:  defect (bug)               |      Status:  closed
 Priority:  normal                     |   Milestone:  5.7
Component:  Revisions                  |     Version:  3.6.1
 Severity:  normal                     |  Resolution:  fixed
 Keywords:  has-patch has-screenshots  |     Focuses:  accessibility
---------------------------------------+----------------------------
Changes (by joedolson):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [50034]

 Revisions: Generate correct number of columns in wp_text_diff.

 The function wp_text_diff generated an invalid table structure if the
 $args parameter contained any values. This patch corrects the structure
 generated by wp_text_diff and related usages so that the column count
 matches the data generated. Additionally, this patch passes arguments to
 the Revisions screen so that the screen has column headings that reflect
 the content in each column. Improves the accessibility and usability of
 the Revisions table.

 Props joedolson, mehulkaklotar, afercia, adamsilverstein, zodiac1978,
 jeremyfelt
 Fixes #25473

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/25473#comment:71>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list