[wp-trac] [WordPress Trac] #52355: Twenty Twenty: remove aria-expanded on Close Search button

[WordPress Trac]

#52355: Twenty Twenty: remove aria-expanded on Close Search button
------------------------------+----------------------------
 Reporter:  alexstine         |       Owner:  alexstine
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  5.7
Component:  Bundled Theme     |     Version:  5.6
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  accessibility
------------------------------+----------------------------
Changes (by joedolson):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"50033" 50033]:
 {{{
 #!CommitTicketReference repository="" revision="50033"
 Twenty Twenty: Remove aria-expanded on search modal close button.

 The Twenty Twenty search modal uses aria-expanded correctly on the Search
 button, but toggles the aria-expanded value on the 'close' button. The
 close button is a different control, however, so the attribute value
 toggling is uneven. The close button does not toggle any behavior; it only
 closes a control that has already been opened.

 Props alexstine, audrasjb
 Fixes #52355
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52355#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform