[wp-trac] [WordPress Trac] #52355: Twenty Twenty: remove aria-expanded on Close Search button

WordPress Trac noreply at wordpress.org
Mon Jan 25 22:47:03 UTC 2021


#52355: Twenty Twenty: remove aria-expanded on Close Search button
------------------------------+----------------------------
 Reporter:  alexstine         |       Owner:  alexstine
     Type:  enhancement       |      Status:  accepted
 Priority:  normal            |   Milestone:  5.7
Component:  Bundled Theme     |     Version:  5.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  accessibility
------------------------------+----------------------------
Changes (by audrasjb):

 * keywords:  has-patch needs-testing => has-patch commit


Comment:

 Hi @alexstine, I tested your patch. It works fine and sounds legit to me.
 Above, I shared two animated screenshot to demonstrate that your patch
 fixes the issue.
 Looks good to go on my side. Removing `needs-testing` workflow keyword and
 replacing it with `commit` :-)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52355#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list