[wp-trac] [WordPress Trac] #52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)

WordPress Trac noreply at wordpress.org
Fri Jan 22 09:25:01 UTC 2021


#52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)
----------------------------------------------------+---------------------
 Reporter:  desrosj                                 |       Owner:  (none)
     Type:  task (blessed)                          |      Status:  new
 Priority:  high                                    |   Milestone:  5.7
Component:  Build/Test Tools                        |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  needs-testing has-patch has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by netweb):

 It's looking like a common theme, happy to approve all the npm,
 package.json, package-lock.json, autoprefixer changes for the following
 PRs as I see the same/similar changes between each of the following PRs

 Note: As per the 5.5 review above, I see the same image additions and
 removals in each of these PRs

 **WordPress 5.4**
 > This ticket was mentioned in PR #886 on WordPress/wordpress-develop by
 desrosj.
 > PR https://github.com/WordPress/wordpress-develop/pull/886 for the
 WordPress 5.4 branch
 - ✅ npm, package.json, and package-lock.json changes are ok
 - ✅ CSS changes via autoprefixer are ok
 - ⚠️ There's various image additions and removals

 **WordPress 5.3**
 > This ticket was mentioned in PR #889 on WordPress/wordpress-develop by
 desrosj.
 > PR https://github.com/WordPress/wordpress-develop/pull/889 for the
 WordPress 5.4 branch
 - ✅ npm, package.json, and package-lock.json changes are ok
 - ✅ CSS changes via autoprefixer are ok
 - ⚠️ There's various image additions and removals


 **WordPress 5.2**
 > This ticket was mentioned in PR #890 on WordPress/wordpress-develop by
 desrosj.
 > PR https://github.com/WordPress/wordpress-develop/pull/890 for the
 WordPress 5.4 branch
 - ✅ npm, package.json, and package-lock.json changes are ok
 - ✅ CSS changes via autoprefixer are ok
 - ✅ Gruntfile changes are ok
 - ⚠️ There's various image additions and removals

 **WordPress 5.1**
 > This ticket was mentioned in PR #891 on WordPress/wordpress-develop by
 desrosj.
 > PR https://github.com/WordPress/wordpress-develop/pull/891 for the
 WordPress 5.4 branch
 - ✅ npm, package.json, and package-lock.json changes are ok
 - ✅ CSS changes via autoprefixer are ok
 - ✅ Gruntfile changes are ok
 - ⚠️ There's various image additions and removals

 **WordPress 5.0**
 > This ticket was mentioned in PR #892 on WordPress/wordpress-develop by
 desrosj.
 > PR https://github.com/WordPress/wordpress-develop/pull/892 for the
 WordPress 5.4 branch
 - ✅ npm, package.json, and package-lock.json changes are ok
 - ✅ CSS changes via autoprefixer are ok
 - ✅ Gruntfile changes are ok
 - ⚠️ There's various image additions and removals

 ----

 **Note:** If the image changes are indeed expected and I've missed
 something as to why they are there, consider this comment for the 5.x
 branches above as +1 for `commit`

 I'll come back and look at the 4.x & 3.x branches in a little while.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52341#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list