[wp-trac] [WordPress Trac] #52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)

[WordPress Trac]

#52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)
----------------------------------------------------+---------------------
 Reporter:  desrosj                                 |       Owner:  (none)
     Type:  task (blessed)                          |      Status:  new
 Priority:  high                                    |   Milestone:  5.7
Component:  Build/Test Tools                        |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  needs-testing has-patch has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by netweb):

 > This ticket was mentioned in PR #885 on WordPress/wordpress-develop by
 desrosj.

 Copy & Paste Review of PR https://github.com/WordPress/wordpress-
 develop/pull/885 for the WordPress 5.5 branch

 ----
 >
 > - ✅ npm, package.json, and package-lock.json changes are ok
 > - ✅ CSS changes via autoprefixer are ok
 > - ⚠️ There's various image changes here in this PR
 >   - A few images removed, `loading.gif` is my biggest concern
 >   - A few images are added
 >
 > In the list of core commits cited in this PR, none of these commits
 relate to any images, so I'm unsure why and where these changes to the
 images comes from in this PR.
 >
 > So, apart from the image changes in this PR it looks good and I would
 have approved the PR if it wasn't for these unknown image changes.

 ----

 Replying to [comment:19 desrosj]:

 > - In each branch, the JS, CSS, and images were updated accordingly. This
 will result in a lot of files being updated in the next update released
 for each branch. However, while I was working on this, it occurred to me
 that the images don't really need to be re-minified. While shrinking their
 size would be nice, we don't have to do that at the same time as the CSS
 or JS, or we could skip it all together for the really old branches.

 Seeing the image notes here from above, the above speaks to re-minifying
 images, not changing images by both removing images and adding images, so
 I'm still unsure why these image changes are in this PR.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52341#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform