[wp-trac] [WordPress Trac] #52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)
WordPress Trac
noreply at wordpress.org
Fri Jan 22 00:19:59 UTC 2021
#52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)
----------------------------------------------------+---------------------
Reporter: desrosj | Owner: (none)
Type: task (blessed) | Status: new
Priority: high | Milestone: 5.7
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: needs-testing has-patch has-unit-tests | Focuses:
----------------------------------------------------+---------------------
Comment (by desrosj):
Few more notes:
- I also did not backport tools that were not present in the branch. For
example, JS documentation linting added in 5.5 was not backported, coding
standards tooling that was added in 5.1 was not backported, etc.
- For the `.nvmrc` file, I currently have `14` as the value. `lts/* was
present in many newer branches, but the best approach for this is not
clear to me. Using 14 would require a commit to each branch moving forward
when new LTS versions are released. But it would also prevent branches
from suddenly failing.
- I updated the `engines` values in the `package.json` file to be ranges,
using `>=`. With the deprecation of `engines-strict`, these values are
merely suggestions, so this seems OK, but open to learning best practices
here.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52341#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list