[wp-trac] [WordPress Trac] #52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)

[WordPress Trac]

#52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)
----------------------------------------------------+---------------------
 Reporter:  desrosj                                 |       Owner:  (none)
     Type:  task (blessed)                          |      Status:  new
 Priority:  high                                    |   Milestone:  5.7
Component:  Build/Test Tools                        |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  needs-testing has-patch has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by desrosj):

 Above all the PRs are attached. Notes about implementation across all
 branches:

 - In branches where an `npm-shrinkwrap.json` file was present, that file
 remains and was updated using `npm shrinkwrap --no-optional`. Where no
 shrinkwrap/lock file was present, I added a `package-lock.json` file. When
 a `package-lock.json` file was present, it was updated. Ideally, we should
 use the same file type in all older branches (thinking shrinkwrap).
 - Each PR has an accompanying PR on the WordPress/WordPress build repo
 mirror. They are linked in each respective PR, or you can find them all
 with
 [https://github.com/WordPress/WordPress/pulls?q=is%3Aclosed+is%3Apr+author%3Adesrosj+Build%2FTest+update
 this link].
 - I did not convert tools. For example, branches that used `grunt-
 cssjanus` remained on `grunt-cssjanus` and were not updated to use `grunt-
 rtlcss`.
 - In each branch, the JS, CSS, and images were updated accordingly. This
 will result in a lot of files being updated in the next update released
 for each branch. However, while I was working on this, it occurred to me
 that the images don't really need to be re-minified. While shrinking their
 size would be nice, we don't have to do that at the same time as the CSS
 or JS, or we could skip it all together for the really old branches.
 - For the most part, the QUnit tests for almost all branches pass with the
 same number of assertions as the [https://travis-ci.com/WordPress
 /wordpress-develop/branches last successful TravisCI build for each
 branch]. One or two branches were displaying some CORS warnings, and I
 believe there was one branch that had less assertions than the last
 successful build. Will investigate this further.
 - I included the local Docker environment in all branches < 4.6 for the
 purposes of easier testing. The 3.7-4.0ish branches are having some issues
 running the install command, but a manual install will successfully set up
 a site.
 - Each branch can be tested by checking out, changing the `LOCAL_DIR` to
 `build` in the `.env` file and running `rm -rf node_modules && npm install
 && npm run env:start && npm run build && npm run env:install`. That will
 give you a working install in the local Docker environment accessible at
 `localhost:8889`.
 - Several branches had outdated browser prefixes present in their CSS
 files. Those have been removed from running `npm run grunt precommit:css`
 and compiled into the respective PR on the build repository. However, all
 changes need to be inspected and confirmed as non-problematic.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52341#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform