[wp-trac] [WordPress Trac] #52534: PHP 8: wp_localize_script() throws a warning if third parameter is a string.

[WordPress Trac]

#52534: PHP 8: wp_localize_script() throws a warning if third parameter is a
string.
-------------------------------------------+------------------------------
 Reporter:  peterwilsoncc                  |       Owner:  (none)
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  Awaiting Review
Component:  Script Loader                  |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  php8 has-patch has-unit-tests  |     Focuses:
-------------------------------------------+------------------------------

Comment (by peterwilsoncc):

 Replying to [comment:11 jrf]:
 > Argh... please disregard the typo in the patch name - `with` should be
 `without`. It's only the name which is borked, not the patch 🤐
 Haha, fortunately I have never made a similar mistake. Well... not today,
 anyway. 🤣

 The changes in [attachment:"52534-with-bc-break.patch"] look good to me.
 The tests show nothing has changed between trunk and with the patch.

 @SergeyBiryukov @jrf I think this is safe to go in to 5.7 but as the first
 RC is only a couple of days away, could one of you sign off on that.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52534#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform