[wp-trac] [WordPress Trac] #52573: user-edit.php throw an empty error notice after clicking the password reset button

WordPress Trac noreply at wordpress.org
Fri Feb 19 14:06:47 UTC 2021


#52573: user-edit.php throw an empty error notice after clicking the password reset
button
----------------------------------------------------+---------------------
 Reporter:  audrasjb                                |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  5.7
Component:  Users                                   |     Version:  trunk
 Severity:  normal                                  |  Resolution:
 Keywords:  has-patch dev-feedback has-screenshots  |     Focuses:  ui
----------------------------------------------------+---------------------

Comment (by SergeyBiryukov):

 Thanks for the patch! I have some concerns about the approach:
 * The `success` parameter is documented as a boolean value, why are we
 comparing it to a string?
 * The `message` parameter is documented as a string, why are we extracting
 it from an array?

 It seems like the `addInlineNotice()` function is not being used correctly
 here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52573#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list