[wp-trac] [WordPress Trac] #52086: user-profile.min.js issue on Firefox

[WordPress Trac]

#52086: user-profile.min.js issue on Firefox
--------------------------+-----------------------------------------
 Reporter:  adi64bit      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.6.2
Component:  Users         |     Version:  5.6
 Severity:  critical      |  Resolution:
 Keywords:                |     Focuses:  javascript, administration
--------------------------+-----------------------------------------

Comment (by jadpm):

 I managed to reproduce this on the following cases:
 - Using `SCRIPT_DEBUG` always turned on, as I experience this in my local
 development setup.
 - With multiple versions of WordPress, since I also use the beta tester
 plugin and this has been happening for some time using a number of
 versions, both stable and nightly builds.
 - Never tried with a vanila installation, but I find it slightly
 irrelevant since this is not a pure compatibility issue (no other libary
 from a third party is causing this), but probably a side effect due to a
 loading race and some natural but probably wrong assumption.

 While `SCRIPT_DEBUG` is on, the error mentions precisely that
 `$toggleButton` is not dfined. I my local debug, I noticed that the
 loading on the `zxcvbn` script changed and got loaded and executed at an
 early point, not sure why as this is a dynamically loaded asset injected
 directly on the header on `windo.load`.

 I assume this might be triggered by some browser combination with some
 parties loading things on `document.ready` and whatnot, but it is indeed
 not easy to replicate and as I stated it does nto even happen all times.

 But in the end, besides tryig to understand the why, the fact is that the
 logid pointed in the above comments show that there is a logic assuption
 an flow which can cause a problem because it is possible to enter a
 decision tree which uses undefined variables. I would suggest focusing on
 that.

 We have a fairly large installation with a medium sized list of plugins
 running with this problem, preventing users from updating their own
 profile.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52086#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform