[wp-trac] [WordPress Trac] #53658: Display a user-facing message when the application passwords functionality is not available
WordPress Trac
noreply at wordpress.org
Fri Dec 17 16:07:47 UTC 2021
#53658: Display a user-facing message when the application passwords functionality
is not available
--------------------------------------+-----------------------------
Reporter: johnbillion | Owner: johnbillion
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.9
Component: Application Passwords | Version: 5.6
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses: administration
--------------------------------------+-----------------------------
Changes (by ocean90):
* keywords: good-first-bug has-patch commit => good-first-bug has-patch
Comment:
Replying to [comment:12 SergeyBiryukov]:
> Good catch! Seems like we can just use
`wp_is_application_passwords_available()` though, instead of duplicating
the checks?
`wp_is_application_passwords_available()` is not just about HTTPS, that's
only the default behaviour. Since it has a filter it can be disabled for
whatever reason. So it can't be used to display a message which is only
about HTTPS.
Though, we could extract the part for the `is_ssl()` and environment check
into a `wp_is_application_passwords_supported()` function which has no
filter so it can be used in `wp_is_application_passwords_available()` and
to display the HTTPS message.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53658#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list