[wp-trac] [WordPress Trac] #54543: Updating Hello Dolly after upgrading 5.0.14 > 5.9.0 Beta 1 fails

[WordPress Trac]

#54543: Updating Hello Dolly after upgrading 5.0.14 > 5.9.0 Beta 1 fails
-----------------------------------------------+---------------------------
 Reporter:  costdev                            |       Owner:
                                               |  hellofromTonya
     Type:  defect (bug)                       |      Status:  closed
 Priority:  normal                             |   Milestone:  5.9
Component:  Upgrade/Install                    |     Version:  trunk
 Severity:  normal                             |  Resolution:  fixed
 Keywords:  has-testing-info has-patch commit  |     Focuses:
-----------------------------------------------+---------------------------
Changes (by hellofromTonya):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"52337" 52337]:
 {{{
 #!CommitTicketReference repository="" revision="52337"
 Upgrade/Install: Fix moving plugins folder in `WP_Upgrader::
 move_to_temp_backup_dir()`.

 [51815] introduced the creation of a temporary backup of plugins before
 updating.

 The `move()` (and later, `move_dir()`) call) uses a `$src` parameter.
 For Hello Dolly, this is `<path>/wp-contents/plugins/.` (note the period
 at the end).

 For users on Linux and Mac, this doesn't appear to cause any problems.
 However, on Windows, the move causes the plugins folder to be moved which
 then causes a failure when attempting to call `mkdir()`.

 This commit skips any plugin whose slug is `'.'` as this slug results in
 the `$src` value ending in a period.

 Follow-up to [51815].

 Props costdev, boniu91, hellofromTonya.
 Fixes #54543.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54543#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform