[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

WordPress Trac noreply at wordpress.org
Mon Dec 6 23:19:55 UTC 2021

#54504: Update Requests library to version 2.0.0
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.0
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php80 php81 has-patch has-unit-      |     Focuses:
  tests early early-like-actually-early          |

Comment (by costdev):

 > @azaozz Also, generally, namespaces should be considered "evil" in open
 source software and avoided as much as possible. The reason it that they
 promote "lazy" names that go against the best practice in writing good
 code (poor self-documenting, confusing names, etc.).

 I'm not sure if this is the right place for a discussion on this, but I'd
 like to hear more about this at some point @azaozz if you're willing. My
 username's the same on Slack if that works for you. Most open source
 software has implemented, or is currently implementing, namespacing. I
 have never seen or heard that namespacing and open source software are, or
 should be, mutually exclusive or have a minimal relationship.

 In terms of going against best practice, that really comes down to a more
 general issue. You can write poorly self-documenting code with or without
 namespaces, or you can write well self-documenting code with or without
 namespaces. There is no consensus in any community that namespaces are
 always poorly self-documenting. It's a difference of opinion within the
 development community, but the contemporary standard is to namespace, and
 that's true across multiple languages.

 Best practice for the survival of open source software has ''always'' been
 to respect:

 1. the wisdom that comes with longer-term contribution.
 2. the right of software to exist alongside each other.
 3. that open source software projects can only survive as long as they
 have contributors, which means that they must adapt to the tried-and-
 tested practices that fuel contemporary development.

 Nearly everything else is down to consensus. Historically, every open
 source software project that has failed to do these is unfortunately no
 longer with us - all of us will have experience of a project we've
 contributed to being closed - It's a sad day when it happens.

 Joomla, Drupal, etc. implement namespacing, as do most other similar open
 source software projects. While we are not those projects, we have a much
 larger reach and therefore rely even more heavily on a strong contributor
 base. Namespaces are only one contemporary standard, but dropping them
 sets a precedent for dropping other contemporary standards and in turn,
 threatens the size of our contributor base.

 In any case, the topic of namespacing within Requests was discussed
 publicly long ago as @jrf said in
 [https://core.trac.wordpress.org/ticket/54504#comment:12 an earlier
 comment]. A lot of work has gone into implementing this and while Requests
 is under the WordPress umbrella, it has a downstream that will also be
 impacted. Experience tells me that if we start down the path of reverting
 contemporary standards, we might as well bundle Requests with Core and
 close the public Requests repo before we watch its usage and contributor
 base steadily reduce in the coming years, followed by Core some years

Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list