[wp-trac] [WordPress Trac] #54036: PclZip throwing errors on PHP 8 - previously merged patch is incomplete

[WordPress Trac]

#54036: PclZip throwing errors on PHP 8 - previously merged patch is incomplete
----------------------------+---------------------
 Reporter:  DavidAnderson   |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  5.9
Component:  Filesystem API  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  php8 has-patch  |     Focuses:
----------------------------+---------------------

Comment (by SergeyBiryukov):

 Thanks for the patch!

 I believe we should check `$p_header['size']` instead of
 `$p_entry['compressed_size']` though, as `$p_entry` is not set in this
 method, and the value passed to `fread()` is `$p_header['size']`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54036#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform