[wp-trac] [WordPress Trac] #54036: PclZip throwing errors on PHP 8 - previously merged patch is incomplete

[WordPress Trac]

#54036: PclZip throwing errors on PHP 8 - previously merged patch is incomplete
----------------------------+---------------------
 Reporter:  DavidAnderson   |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  5.9
Component:  Filesystem API  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  php8 has-patch  |     Focuses:
----------------------------+---------------------
Changes (by SergeyBiryukov):

 * keywords:   => php8 has-patch
 * milestone:  Awaiting Review => 5.9


Old description:

> The patch merged in https://core.trac.wordpress.org/ticket/52018 is
> incomplete, and when using `PclZip::add()`, you can still get fatal
> errors.
>
> In UpdraftPlus (where we've had a number of affected users), the trace
> (from the relevant point onwards) is:
>
> `UpdraftPlus_Backup->makezip_addfiles, UpdraftPlus_PclZip->close,
> PclZip->add, PclZip->privAdd, PclZip->privAddFileList,
> PclZip->privAddFile`
>
> A patch is being attached.

New description:

 The patch merged in #52018 is incomplete, and when using `PclZip::add()`,
 you can still get fatal errors.

 In UpdraftPlus (where we've had a number of affected users), the trace
 (from the relevant point onwards) is:

 `UpdraftPlus_Backup->makezip_addfiles, UpdraftPlus_PclZip->close,
 PclZip->add, PclZip->privAdd, PclZip->privAddFileList,
 PclZip->privAddFile`

 A patch is being attached.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54036#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform