[wp-trac] [WordPress Trac] #35217: WP_Upgrader: writes temporary directory name to plugin folder if zip doesn't have directory

[WordPress Trac]

#35217: WP_Upgrader:  writes temporary directory name to plugin folder if zip
doesn't have directory
-----------------------------+---------------------
 Reporter:  basszje          |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:
Component:  Upgrade/Install  |     Version:  4.4
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+---------------------

Comment (by poena):

 Using the testing instructions and code provided in
 https://core.trac.wordpress.org/ticket/30476, (with updated remote link),
 I was able to reproduce this by remotely fetching a plugin zip file that
 had no directories inside of it.

 The name of the zip file was hello-dolly.zip and the resulting folder name
 were in the likes of "hello-dolly-B3W8Xu", "hello-dolly-moENyt".

 The random name is generated at
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/file.php#L677 via download_url,
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/file.php#L1086

 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
 wp-upgrader.php#L283

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/35217#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform