[wp-trac] [WordPress Trac] #49576: Menu Editor UI issues on med-large screens

[WordPress Trac]

#49576: Menu Editor UI issues on med-large screens
-------------------------------------+-------------------------------------
 Reporter:  garrett-eclipse          |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.6
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots needs-   |     Focuses:  ui, css,
  testing has-patch                  |  administration
-------------------------------------+-------------------------------------
Changes (by garrett-eclipse):

 * keywords:  has-screenshots needs-testing has-patch needs-refresh => has-
     screenshots needs-testing has-patch


Comment:

 Replying to [comment:16 afercia]:
 > @garrett-eclipse looking at the alternative approach, looks like a good
 approach. Couple considerations:
 > - I wouldn't add a new breakpoint `min-width: 783px`, that would be
 unprecedented in core. I'd tend to think we should try to reuse existing
 breakpoints. Would it be possible to reverse the approach? As in: add
 those rules by default and reset them when less than 782px.
 > - I see you're testing when no menu exists. When a menu with items
 nested by 2-3 levels is set, this page responsive behavior is pretty
 different and basically breaks for viewport widths between about 950 / 782
 pixels. This is a pre-existing issue unrelated to this patch. Just to note
 that this page has more serious, long-standing, layout issues that would
 require a major refactoring. In a separate ticket :)

 Thanks @afercia I appreciate the feedback. I've updated the implementation
 to avoid a new media query in
 [https://core.trac.wordpress.org/attachment/ticket/49576/49576.3.diff
 49576.3.diff]. I think it just needs some testing and is good to go.

 Through the review process there was mention of the dual buttons on many
 occasion as well as the layout issues you mentioned. These I feel are out
 of the scope of this ticket and more an enhancements so don't want them to
 derail this fix. As such I opened #51631 to address those items in a
 future release as an enhancement.

 @afercia / @audrasjb could you retest and see if we can get this in before
 Beta 2.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49576#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform