[wp-trac] [WordPress Trac] #50538: WP_Comments_List_Table should not show views that have a count of 0
WordPress Trac
noreply at wordpress.org
Sun Oct 11 02:47:07 UTC 2020
#50538: WP_Comments_List_Table should not show views that have a count of 0
-------------------------------------------------+-------------------------
Reporter: pbiron | Owner: pbiron
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.6
Component: Comments | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch needs- | Focuses:
design-feedback needs-refresh | administration
-------------------------------------------------+-------------------------
Comment (by garrett-eclipse):
I will revoice my concern with suppressing potential status' as providing
them with '0's gives you an idea as to what potential status' to expect.
Refering to
[https://core.trac.wordpress.org/ticket/47495?replyto=4#comment:4
comment:4;core#47495]:
> Thanks @pbiron for the ticket and patch, applying and testing the patch
works as outlined.
>
> I am a bit hesitant of moving forward here as I see Requests being more
in line with Comments than posts and the Comments list table does display
the additional status' for Pending, Approved, Spam and Trash.
> [[Image(https://core.trac.wordpress.org/raw-
attachment/ticket/47495/Screen%20Shot%202020-04-21%20at%2012.38.14%20AM.png)]]
>
> In my eyes displaying all status' is helpful to the user experience as
it outlines the expected process visually by showing what status buckets
the requests will need to pass through.
>
> I'm marking for 2nd-opinion and also flagging to get some design
feedback on the UX here. I'm all for consistency so if it's decided to
suppress empty status labels then we should also address the Comments list
table or potentially vice versa if displaying them is useful for to the
user for the interface then resurfacing them on other list tables may be
the avenue forward.
That being said following my comment there was design discussion;
Replying to
[https://core.trac.wordpress.org/ticket/47495?replyto=8#comment:8
comment:8#47495 at mapk]:
> The Design Team discussed this [in Slack
today]https://wordpress.slack.com/archives/C02S78ZAL/p1593708788256000.
We're in agreement that the 0 count views should be hidden.
Maybe @mapk or @pbiron can elaborate on that design decision, or it can be
re-raised into a design meeting.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50538#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list