[wp-trac] [WordPress Trac] #50898: PHP 8.0: only call libxml_disable_entity_loader() in PHP < 8

[WordPress Trac]

#50898: PHP 8.0: only call libxml_disable_entity_loader() in PHP < 8
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.6
Component:  Embeds                               |     Version:
 Severity:  minor                                |  Resolution:  fixed
 Keywords:  has-patch php8 needs-dev-note        |     Focuses:  coding-
  commit                                         |  standards
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"49621" 49621]:
 {{{
 #!CommitTicketReference repository="" revision="49621"
 Code Modernization: Only call `libxml_disable_entity_loader()` in PHP < 8.

 This function has been deprecated in PHP 8.0 because in libxml 2.9.0,
 external entity loading is disabled by default, so this function is no
 longer needed to protect against XXE attacks.

 This change fixes an instance of `libxml_disable_entity_loader()` within
 the getID3 library that has not yet been included in a tagged release for
 the library.

 Props jrf, hellofromtonya.
 Fixes #50898.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50898#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform