[wp-trac] [WordPress Trac] #50898: PHP 8.0: only call libxml_disable_entity_loader() in PHP < 8

WordPress Trac noreply at wordpress.org
Tue Nov 17 00:13:54 UTC 2020


#50898: PHP 8.0: only call libxml_disable_entity_loader() in PHP < 8
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.6
Component:  Embeds                               |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-patch php8 needs-dev-note        |     Focuses:  coding-
  commit                                         |  standards
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch php8 needs-dev-note => has-patch php8 needs-dev-note
     commit


Comment:

 @desrosj Reviewing the patch
 [https://core.trac.wordpress.org/attachment/ticket/50898/50898-getid3.2.diff
 50898-getid3.2.diff], it looks good. It matches the combination of
 https://github.com/JamesHeinrich/getID3/pull/260 and
 https://github.com/JamesHeinrich/getID3/pull/261. Ship it!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50898#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list