[wp-trac] [WordPress Trac] #51423: Fix function argument type issues reported by PHPStan

[WordPress Trac]

#51423: Fix function argument type issues reported by PHPStan
-------------------------------------------+-------------------------------
 Reporter:  SergeyBiryukov                 |       Owner:  SergeyBiryukov
     Type:  task (blessed)                 |      Status:  accepted
 Priority:  normal                         |   Milestone:  5.6
Component:  General                        |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  php8 has-patch has-unit-tests  |     Focuses:  coding-standards
-------------------------------------------+-------------------------------

Comment (by hellofromTonya):

 Replying to [comment:40 jrf]:
 >At the request of @hellofromTonya I've reviewed
 [https://github.com/WordPress/wordpress-develop/pull/736 PR #736] now and
 left an extensive comment for you to consider:
 https://github.com/WordPress/wordpress-
 develop/pull/736#pullrequestreview-528734649
 >
 >The feedback I left there might also help inform how to handle some of
 the other changes needed.
 >
 >Hope it helps!

 Your thorough and extensive comment gave me an Aha Moment! I can now
 clearly see both the goal of this ticket, the process, and next steps for
 all of its patches/PRs.

 The **goal of this ticket** is to match the data types of each function
 parameter, i.e. as part of the PHP 8 compatibility.

 We should seek:
 - to retain the current behavior (i.e. to avoid breaking changes)
 - to retain the triggering of notice/warning/error, which are clues and
 indicators (i.e. rather than silently letting the problem propagate
 downstream)
 - to gain PHP 8 compatibility

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51423#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform