[wp-trac] [WordPress Trac] #51423: Fix function argument type issues reported by PHPStan
WordPress Trac
noreply at wordpress.org
Thu Nov 12 04:11:36 UTC 2020
#51423: Fix function argument type issues reported by PHPStan
-------------------------------------------+-------------------------------
Reporter: SergeyBiryukov | Owner: SergeyBiryukov
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 5.6
Component: General | Version:
Severity: normal | Resolution:
Keywords: php8 has-patch has-unit-tests | Focuses: coding-standards
-------------------------------------------+-------------------------------
Comment (by jrf):
Hi @xknown and @hellofromTonya, thank you so much for taking this on,
breaking the changes up into individual PRs and adding tests. This will
definitely make it easier to review and discuss the proposed changes.
At the request of @hellofromTonya I've reviewed
[https://github.com/WordPress/wordpress-develop/pull/736 PR #736] now and
left an extensive comment for you to consider:
https://github.com/WordPress/wordpress-
develop/pull/736#pullrequestreview-528734649
The feedback I left there might also help inform how to handle some of the
other changes needed.
Hope it helps!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51423#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list