[wp-trac] [WordPress Trac] #9757: Allow Plugin/Theme updates from a uploaded .zip file.

[WordPress Trac]

#9757: Allow Plugin/Theme updates from a uploaded .zip file.
-------------------------------------------------+-------------------------
 Reporter:  hakre                                |       Owner:  (none)
     Type:  feature request                      |      Status:  assigned
 Priority:  high                                 |   Milestone:  Future
                                                 |  Release
Component:  Upgrade/Install                      |     Version:  2.8
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-patch early needs-  |     Focuses:  ui-copy
  screenshots 2nd-opinion                        |
-------------------------------------------------+-------------------------

Comment (by mariovalney):

 Thank you for all the points.

 >`Compare before retry` doesn't sound quite right imho. The users can make
 a decision to upgrade/downgrade at this point. They are not retrying to
 install again.

 Retry install (uograde/downgrade) because already failed.

 >`Seems like you are trying to upload a [plugin|theme] already
 installed.`. Something like that could probably be used instead of
 "Compare before retry"?

 Nice. Added a todo.
 ''Ooh... PR comments appears here...''

 >Would be good to show "Backup your site before upgrading" warning imho.

 Agreed! We don't show this to regular upload, but as this patches allow
 users upgrade/downgrade without much validation (because I thinks there's
 not way to garantee this is  a upgrade/downgrade) would be good.

 Just like core ones?

 ----

 **Important:** Before upgrade/downgrade your plugin[theme], please
 [https://wordpress.org/support/article/wordpress-backups/ back up your
 database and files].

 ----


 >Also not sure if this is particularly useful:
 https://github.com/WordPress/wordpress-develop/pull/267/files#diff-
 84f206c9515d9ad843b821ac8d8d526cR287-R290.

 I was not able to be sure about which part of code are you talking about.

 Maybe about the current theme error? I added it because WP treats invalid
 themes in another way of valid themes (another UI on list theme, for
 example, and not shows it on "add theme" page). So maybe makes sense to
 highlight that.

 >That might be good, but is part of Site Health. Far more useful would be
 to know if the uploaded plugin/theme has obvious errors.

 We can add the [https://core.trac.wordpress.org/ticket/9757#comment:86
 check Clorith talked about].

 Actually would be great to add this to regular install too. Is it
 possible? Any direction to point me?


 >Speaking of errors, thinking it would be good to check whether the
 requirements for the plugin/theme are met? Like minimum WP version and PHP
 version. Discrepancies may get highlighted in the compare table, but seems
 the upgrade would still be allowed even if not compatible.

 Good point. Let's add this on "regular install" (check_package method)
 too?
 Thsi way we improve it and will not fall on "ovewrite install" in first
 place.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/9757#comment:132>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform