[wp-trac] [WordPress Trac] #9757: Allow Plugin/Theme updates from a uploaded .zip file.

[WordPress Trac]

#9757: Allow Plugin/Theme updates from a uploaded .zip file.
-------------------------------------------------+-------------------------
 Reporter:  hakre                                |       Owner:  (none)
     Type:  feature request                      |      Status:  assigned
 Priority:  high                                 |   Milestone:  Future
                                                 |  Release
Component:  Upgrade/Install                      |     Version:  2.8
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-patch early needs-  |     Focuses:  ui-copy
  screenshots 2nd-opinion                        |
-------------------------------------------------+-------------------------
Changes (by azaozz):

 * keywords:  dev-feedback has-patch early needs-screenshots => dev-feedback
     has-patch early needs-screenshots 2nd-opinion
 * focuses:   => ui-copy


Comment:

 Yes, the workflow/UI is looking good. Perhaps the text strings (copy) can
 have another look, hoping somebody may have better ideas for there:

 - `Compare before retry` doesn't sound quite right imho. The users can
 make a decision to upgrade/downgrade at this point. They are not retrying
 to install again.
 - `Seems like you are trying to upload a [plugin|theme] already
 installed.`. Something like that could probably be used instead of
 "Compare before retry"? It comes after "Destination exists...",
 "Installation failed...", see the screenshot in
 [https://core.trac.wordpress.org/ticket/9757#comment:120 comment 120].

 Also not sure if this is particularly useful: https://github.com/WordPress
 /wordpress-develop/pull/267/files#diff-
 84f206c9515d9ad843b821ac8d8d526cR287-R290. As far as I see it shows if
 there in an error with the currently installed theme. That might be good,
 but is part of Site Health. Far more useful would be to know if the
 uploaded plugin/theme has obvious errors.

 Speaking of errors, thinking it would be good to check whether the
 requirements for the plugin/theme are met? Like minimum WP version and PHP
 version. Discrepancies may get highlighted in the compare table, but seems
 the upgrade would still be allowed even if not compatible.

 Going to ping @dd32 for a look as this patch uses `install()` to do
 upgrade, see https://core.trac.wordpress.org/ticket/9757#comment:60. Using
 `install()` is pretty much like using FTP to replace the plugin's
 directory but is missing several steps that are normally performed when
 upgrading, see https://core.trac.wordpress.org/browser/tags/5.4.1/src/wp-
 admin/includes/class-plugin-upgrader.php#L169.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/9757#comment:129>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform