[wp-trac] [WordPress Trac] #48916: Twenty Twenty: anchor links don't work in mobile menu

[WordPress Trac]

#48916: Twenty Twenty: anchor links don't work in mobile menu
-------------------------------------+-------------------------
 Reporter:  Giorgio25b               |       Owner:  (none)
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  5.5
Component:  Bundled Theme            |     Version:  5.3
 Severity:  normal                   |  Resolution:  worksforme
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+-------------------------
Changes (by Giorgio25b):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Replying to [comment:10 ianbelanger]:
 > Thanks for all of your work on this @Giorgio25b, @bdcstr, @samful,
 @yuhin and @suzylah. I have just uploaded an updated patch that includes a
 check to see if the modal is active. After applying @Giorgio25b patch
 clicking on an anchor link that was not in the modal would throw an error
 in the console.
 >
 > `Uncaught TypeError: Cannot read property 'dataset' of null`
 >
 > My patch fixes this by adding a check to make sure that `modal` is not
 `null`.
 >
 > Testing on multiple different devices would be appreciated.

 Hi @ianbelanger , thanks for the attention to details!
 I've pushed a comprehensive PR with a fully tested patch (local, live,
 mobile, tablet, win/mac, etc).
 You can find it here, I wasn't sure if your diff push was requiring a new
 PR, but just in case ;-)
 [https://github.com/WordPress/wordpress-
 develop/pull/254/commits/b58ce5062a390413cea7aed317186dd417b4071f#diff-
 d25e57a01a8a4bcabdb796cfefbe4b63R141]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48916#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform