[wp-trac] [WordPress Trac] #48916: Twenty Twenty: anchor links don't work in mobile menu

[WordPress Trac]

#48916: Twenty Twenty: anchor links don't work in mobile menu
-------------------------------------+-------------------------
 Reporter:  Giorgio25b               |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.5
Component:  Bundled Theme            |     Version:  5.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+-------------------------
Changes (by ianbelanger):

 * milestone:  Future Release => 5.5


Comment:

 Thanks for all of your work on this @Giorgio25b, @bdcstr, @samful, @yuhin
 and @suzylah. I have just uploaded an updated patch that includes a check
 to see if the modal is active. After applying @Giorgio25b patch clicking
 on an anchor link that was not in the modal would throw an error in the
 console.

 `Uncaught TypeError: Cannot read property 'dataset' of null`

 My patch fixes this by adding a check to make sure that `modal` is not
 `null`.

 Testing on multiple different devices would be appreciated.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48916#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform