[wp-trac] [WordPress Trac] #50367: Avoid layout shifting due to images not having dimension attributes

WordPress Trac noreply at wordpress.org
Tue Jun 30 19:28:22 UTC 2020


#50367: Avoid layout shifting due to images not having dimension attributes
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.5
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  needs-testing has-patch has-unit-    |     Focuses:
  tests needs-dev-note                           |
-------------------------------------------------+-------------------------
Changes (by flixos90):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"48237" 48237]:
 {{{
 #!CommitTicketReference repository="" revision="48237"
 Media: Introduce `wp_img_tag_add_width_and_height_attr()` to add dimension
 attributes to images.

 Following up on [48170], this changeset moves the new logic to add missing
 `img` dimension attributes into a separate function that is run first
 within `wp_filter_content_tags()`. It also adds a utility function
 `wp_image_src_get_dimensions()` with logic reused from
 `wp_image_add_srcset_and_sizes()`, and it ensures that `width` and
 `height` attributes only get added if both of the attributes are missing
 on the original `img` tag.

 This changeset furthermore improves test coverage and separates tests for
 the different aspects of `img` tag modification.

 Props azaozz.
 Fixes #50367. See #44427.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50367#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list