[wp-trac] [WordPress Trac] #16557: Ability to disable redirect_guess_404_permalink()

[WordPress Trac]

#16557: Ability to disable redirect_guess_404_permalink()
-------------------------------------------------+-------------------------
 Reporter:  msafi                                |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.5
Component:  Canonical                            |     Version:  3.1
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:
  tests commit                                   |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:58 johnbillion]:
 > My preference is to go with `Returning a false value from the filter`,
 because the filter is the callback function added with `add_filter()`,
 therefore the hook passes a value to the filter, and the filter returns a
 value to change its behaviour. The documentation is referring to the
 latter.
 >
 > I ''think'' this makes more sense, what do you think? Happy to discuss
 here or in a separate ticket.

 Thanks for catching that! I went back and forth for a bit and chose what
 seemed more consistent at the time.

 I agree, happy to switch to your suggestion. Does [attachment:49572
 .returning-from-filter.diff:ticket:49572] look good?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/16557#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform