[wp-trac] [WordPress Trac] #16557: Ability to disable redirect_guess_404_permalink()

WordPress Trac noreply at wordpress.org
Fri Jun 26 17:43:08 UTC 2020


#16557: Ability to disable redirect_guess_404_permalink()
-------------------------------------------------+-------------------------
 Reporter:  msafi                                |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.5
Component:  Canonical                            |     Version:  3.1
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:
  tests commit                                   |
-------------------------------------------------+-------------------------

Comment (by johnbillion):

 @SergeyBiryukov In [47885] you switched the docs from saying `Returning a
 false value from the filter` to saying `Passing a false value to the
 filter`.

 There's a mixture in core of using `returning from` versus `passing to`
 for the docs for short-circuit (and similar) filters.

 My preference is to go with `Returning a false value from the filter`,
 because the filter is the callback function added with `add_filter()`,
 therefore the hook passes a value to the filter, and the filter returns a
 value to change its behaviour. The documentation is referring to the
 latter.

 I ''think'' this makes more sense, what do you think? Happy to discuss
 here or in a separate ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/16557#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list