[wp-trac] [WordPress Trac] #49446: cache the results of get_uploaded_header_images()

WordPress Trac noreply at wordpress.org
Thu Jun 18 22:28:51 UTC 2020


#49446: cache the results of get_uploaded_header_images()
------------------------------+------------------------------------------
 Reporter:  pbiron            |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  5.5
Component:  Cache API         |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  administration, performance
------------------------------+------------------------------------------
Changes (by SergeyBiryukov):

 * keywords:   => has-patch commit


Comment:

 Replying to [comment:7 pbiron]:
 > I wasn't aware of the `@staticvar` tag, so I went to
 [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#phpdoc-tags PHP Documentation Standards]
 handbook page and don't see it listed as one of the tags (altho a quick
 search thru the core source, I see ~100 uses).
 > ...
 > Should the handbook be updated to mention `@staticvar`?

 Yes, it's used in core but for some reason not mentioned in the handbook.

 Note that it's different from the `@static` tag that was removed in
 #42803.

 > p.s. is this ready to commit now?

 I think so :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49446#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list