[wp-trac] [WordPress Trac] #49446: cache the results of get_uploaded_header_images()

WordPress Trac noreply at wordpress.org
Thu Jun 18 21:51:12 UTC 2020


#49446: cache the results of get_uploaded_header_images()
-------------------------+------------------------------------------
 Reporter:  pbiron       |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  5.5
Component:  Cache API    |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:  administration, performance
-------------------------+------------------------------------------

Comment (by pbiron):

 I wasn't aware of the `@staticvar` tag, so I went to
 [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#phpdoc-tags PHP Documentation Standards]
 handbook page and don't see it listed as one of the tags (altho a quick
 search thru the core source, I see ~100 uses).

 The handbook page does have an entry for `@static` that states:

 > Note: This tag has been used in the past, but should no longer be used.
 Just using the static keyword in your code is enough for PhpDocumentor on
 PHP5 to recognize static variables and methods, and PhpDocumentor will
 mark them as static

 Should the handbook be updated to mention `@staticvar`?

 p.s. is this ready to commit now?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49446#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list