[wp-trac] [WordPress Trac] #37011: Don’t link custom logo if it’s displayed on the front page

[WordPress Trac]

#37011: Don’t link custom logo if it’s displayed on the front page
------------------------------------------------+--------------------------
 Reporter:  FlorianBrinkmann                    |       Owner:  joedolson
     Type:  enhancement                         |      Status:  reopened
 Priority:  highest omg bbq                     |   Milestone:  5.5
Component:  Themes                              |     Version:  4.6
 Severity:  blocker                             |  Resolution:
 Keywords:  has-patch has-dev-note 2nd-opinion  |     Focuses:
                                                |  accessibility
------------------------------------------------+--------------------------
Changes (by audrasjb):

 * keywords:  has-patch has-dev-note => has-patch has-dev-note 2nd-opinion
 * priority:  normal => highest omg bbq
 * severity:  normal => blocker


Comment:

 `37011.diff` fixes the backward compatibility issue pointed out in the dev
 note.

 It introduces `unlink-homepage-logo` parameter for `custom-logo` theme
 support option and use it to determine whether to link or unlink the logo
 on the homepage.

 By default, `unlink-homepage-logo` is set to false.

 Theme authors can opt-in for the change using for example this snippet:

 {{{
         add_theme_support(
                 'custom-logo',
                 array(
                         'height'               => $logo_height,
                         'width'                => $logo_width,
                         'flex-height'          => true,
                         'flex-width'           => true,
                         'unlink-homepage-logo' => true, // HERE !
                 )
         );
 }}}

 (this can be used to replace the existing bits of code in Twenty Twenty)

 For 5.5, I'd suggest to commit it as it and to implement the `unlink-
 homepage-logo` parameter to bundle themes after 5.5 is released, as
 bundled themes can be released independantly from Core.

 @SergeyBiryukov do you have any thought on this approach, as WP 5.5 Tech
 Lead?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37011#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform