[wp-trac] [WordPress Trac] #50670: Upgrader implementation ignore UpgraderSkin interfaces

[WordPress Trac]

#50670: Upgrader implementation ignore UpgraderSkin interfaces
-------------------------------------------+---------------------
 Reporter:  schlessera                     |       Owner:  (none)
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  5.5
Component:  Plugins                        |     Version:  trunk
 Severity:  normal                         |  Resolution:
 Keywords:  needs-patch reporter-feedback  |     Focuses:
-------------------------------------------+---------------------
Changes (by azaozz):

 * keywords:   => needs-patch reporter-feedback


Comment:

 Seems to happen only for themes. Caused by `Theme_Upgrader` missing a
 conditional that is in `Plugin_Upgrader`. See
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
 theme-upgrader.php#L97 and
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
 plugin-upgrader.php#L89.

 What would be the best fix here? Adding `private $is_downgrading = false;`
 to `WP_Upgrader_Skin` or the conditional, or both? :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50670#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform