[wp-trac] [WordPress Trac] #48222: "Show password" button overlaps with the LastPass icon

[WordPress Trac]

#48222: "Show password" button overlaps with the LastPass icon
-----------------------------------------------------+---------------------
 Reporter:  SergeyBiryukov                           |       Owner:  (none)
     Type:  defect (bug)                             |      Status:  new
 Priority:  normal                                   |   Milestone:  5.4
Component:  Login and Registration                   |     Version:  5.3
 Severity:  normal                                   |  Resolution:
 Keywords:  has-screenshots has-patch needs-refresh  |     Focuses:  ui
-----------------------------------------------------+---------------------

Comment (by afercia):

 Looking a bit more in depth:
 - as mentioned in a previous comment, the clickable area is a bit too
 small: we're down from the previous 40 by 40 pixels to 50 by 20 pixels:
 the height is too small especially for touch on small screens, not to
 mention accessibility
 - the focus style could be improved a bit (see screenshot below)
 - as there's now visible text, there's no need to have an `aria-label`: it
 should be removed together with the JS part meant to update its value
 - some CSS values seem a bit "magic numbers", for example `line-height:
 2.15;` based on `font-size: 12px;` computes to `25.8` pixels: it would be
 nice to have some meaningful numbers instead (with no decimals)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48222#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform