[wp-trac] [WordPress Trac] #48222: "Show password" button overlaps with the LastPass icon

[WordPress Trac]

#48222: "Show password" button overlaps with the LastPass icon
-----------------------------------------------------+---------------------
 Reporter:  SergeyBiryukov                           |       Owner:  (none)
     Type:  defect (bug)                             |      Status:  new
 Priority:  normal                                   |   Milestone:  5.4
Component:  Login and Registration                   |     Version:  5.3
 Severity:  normal                                   |  Resolution:
 Keywords:  has-screenshots has-patch needs-refresh  |     Focuses:  ui
-----------------------------------------------------+---------------------
Changes (by afercia):

 * keywords:  has-screenshots dev-feedback has-patch needs-testing => has-
     screenshots has-patch needs-refresh


Comment:

 Replying to [comment:38 Clorith]:
 > I'm not a fan of the markup here, to reach the button to toggle
 visibility one would then have to navigate backwards, and would also be
 exposed to a potentially contextless "Show" before even being presented
 with the input.

 I agree with @Clorith.
 UI controls need to make sense also when read out of context. A
 contextless "Show" would be the equivalent of a "Read more" link that
 doesn't specify the "what".

 Re: the order: many users experience the content in a linearized way.
 Keyboard users, screen reader users, etc. The order of elements needs to
 be logical: first the "what", and then the actions related to the "what"
 object.

 The option 2 on comment:34 is the only one that satisfies these needs.

 Also, looking at [attachment:"48222.5.diff"] :
 - there's a missing semicolon in `wp-login.php` at line 968 which throws a
 PHPCS error: `<?php _e( 'Hide' ) ?>`
 - the CSS class `button-secondary` is deprecated and can be removed: it's
 a pre-existing issue but since we're here... See [38672].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48222#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform