[wp-trac] [WordPress Trac] #47327: Avoid italic text for better accessibility and readability

WordPress Trac noreply at wordpress.org
Tue Feb 18 10:01:12 UTC 2020


#47327: Avoid italic text for better accessibility and readability
------------------------------------------------+--------------------------
 Reporter:  afercia                             |       Owner:  audrasjb
     Type:  defect (bug)                        |      Status:  assigned
 Priority:  normal                              |   Milestone:  5.4
Component:  Administration                      |     Version:
 Severity:  normal                              |  Resolution:
 Keywords:  has-screenshots italic-text commit  |     Focuses:  ui,
                                                |  accessibility
------------------------------------------------+--------------------------
Changes (by afercia):

 * keywords:  has-screenshots italic-text => has-screenshots italic-text
     commit


Comment:

 [attachment:"47327.2.diff"]
 - Adds the 8 pixels bottom padding making sure to exclude the "Restore
 Original Image" box
 - Changes the `inline-edit-or` text ("–OR–") displayed in the Quick Edit
 form from `<em>` to `<span>`: `<em>` is meant for semantic emphasis which
 is not appropriate in this case
 - In the Image Editor: the Thumbnail Settings help was a `<p>` element
 while all the other ones are `<div>` wrapping a paragraph. This seems to
 be the case since its introduction in [11965]. Changed to a `<div>` that
 wraps a paragraph for consistency. Also, this way the jQuery animation
 runs on an element that has no top/bottom margins (while paragraphs
 inherit margins) so it runs without "jumpiness".

 Looks good to me. Tested the Image Editor help also in the media modal.

 When committing, please keep the ticket open as this is an in-progress
 work that will span across multiple releases.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47327#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list