[wp-trac] [WordPress Trac] #50992: Consider removing the ability to alter the list of environment types

[WordPress Trac]

#50992: Consider removing the ability to alter the list of environment types
------------------------------------+--------------------------
 Reporter:  johnbillion             |       Owner:  johnbillion
     Type:  defect (bug)            |      Status:  closed
 Priority:  normal                  |   Milestone:  5.5.1
Component:  Bootstrap/Load          |     Version:  5.5
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  has-patch has-dev-note  |     Focuses:
------------------------------------+--------------------------

Comment (by giuseppe.mazzapica):

 Is not this a BC break change?

 Besides agreeing or not with the matter, I can tell that in one of the
 websites that I'm working on to I have two environments, "prod-eu" and
 "prod-us" and based on
 environment things like API keys changes. I used to manage those env vars
 on my own but decided to do the "WordPress way" for WP 5.5.

 Now I need to change the workflow again. I can't use a database because
 the first check happens before WP is loaded, I'll probably revert back to
 my own environment management.

 My point is that when support for a constant is added, it should not be
 removed in a** bugfix release** that, as you know, might happen to be
 pushed overnight on environments via automatic updates.

 I see you added a deprecation notice if WP_ENVIRONMENT_TYPES is defined,
 why not _just_ keep this notice and wait at list next minor to remove
 support?

 Is not that the point of deprecation notices? First you deprecate, in next
 version you remove. Or am I wrong?

 But I guess is too late now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50992#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform