[wp-trac] [WordPress Trac] #46149: PHPUnit 8.x support
WordPress Trac
noreply at wordpress.org
Fri Aug 21 00:08:37 UTC 2020
#46149: PHPUnit 8.x support
--------------------------------------------+-----------------------
Reporter: SergeyBiryukov | Owner: netweb
Type: task (blessed) | Status: assigned
Priority: high | Milestone: 5.6
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests early | Focuses:
--------------------------------------------+-----------------------
Comment (by jrf):
> Just noting that the void return type hinting was introduced in PHP 7.1,
so unless I'm missing something, PHP 7.1 should be able to run the newer
syntax without any modifications, I think they are only needed for 5.6 and
7.0. Is that assumption wrong?
Yes and no. Void is not the problem for PHP 7.1. The problem there is that
PHPUnit 7 is still needed - PHPUnit 8 has a minimum requirement of PHP 7.2
- and if per @dd32 comment above, the test suite will be standardized on
PHPUnit8/9 assert calls (which I support as the sensible thing to do),
then some of those assertions will either need wrappers, like the traits I
created in the original PR, or the proposed bash script will need to run
to "rewrite" some of those assertions to their old name/ to the old way of
doing that assertion.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46149#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list