[wp-trac] [WordPress Trac] #46149: PHPUnit 8.x support
WordPress Trac
noreply at wordpress.org
Thu Aug 20 20:16:13 UTC 2020
#46149: PHPUnit 8.x support
--------------------------------------------+-----------------------
Reporter: SergeyBiryukov | Owner: netweb
Type: task (blessed) | Status: assigned
Priority: high | Milestone: 5.6
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests early | Focuses:
--------------------------------------------+-----------------------
Comment (by SergeyBiryukov):
Replying to [comment:38 dd32]:
> I've taken my above PR and forked it into a
[https://github.com/WordPress/wordpress-develop/pull/491 new PR 491] which
does two things, which I think is a reasonable middleground
> - Standardises on PHPUnit8/9 assert calls, requires PHP 7.2+ to run.
> - Includes a bash script for use on Travis to remove the void return
type hinting so that Travis can still run the Unit tests for PHP 5.6, 7.0,
and 7.1.
Just noting that the `void` return type hinting
[https://www.php.net/manual/en/migration71.new-features.php was introduced
in PHP 7.1], so unless I'm missing something, PHP 7.1 should be able to
run the newer syntax without any modifications, I think they are only
needed for 5.6 and 7.0. Is that assumption wrong?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46149#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list