[wp-trac] [WordPress Trac] #46149: PHPUnit 8.x support

[WordPress Trac]

#46149: PHPUnit 8.x support
--------------------------------------+-----------------------
 Reporter:  SergeyBiryukov            |       Owner:  netweb
     Type:  task (blessed)            |      Status:  assigned
 Priority:  normal                    |   Milestone:  5.6
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------

Comment (by jrf):

 Hmm.. something weird going on with the GH bot as my response which should
 be between those last two comments did not get cross-posted.

 Quoting it here now for completeness:

 > > This pretty much rules out PHP 5.6 being dropped in WP 5.6, that usage
 is far too high to consider dropping it, the considerations historically
 have been to consider if usage drops below 5%
 >
 > @ntwb Dropping PHP 5.6 support is on the
 [https://make.wordpress.org/core/2020/08/13/wordpress-5-6-release-
 planning/ roadmap for WP 5.6], so IMO this is a foregone conclusion.
 >
 > I did ask for confirmation before working on this patch and wouldn't
 have bothered spending this much time on getting it set up if that
 intention hadn't been clarified.
 >
 > > Would it be worth setting up or changing the existing jobs to use
 newer versions of PHPUnit?
 >
 > No, that is not an option because of the `void` return type introduced
 for all fixtures in PHPUnit 8.
 > Return types were only introduced in PHP 7.0, the `void` return type in
 PHP 7.1, so it is not easy to make the test suite cross-version compatible
 with both PHPUnit 7 as well as PHPUnit 8 if the test suite also still has
 to be compatible with PHP 5.6/7.0.
 >
 > There is a way to do it, but I would strongly recommend against it if it
 can be avoided in any conceivable way. IMO dropping support for PHP 5.6
 and 7.0 is the much better choice.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46149#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform