[wp-trac] [WordPress Trac] #46149: PHPUnit 8.x support
WordPress Trac
noreply at wordpress.org
Sun Aug 16 18:19:28 UTC 2020
#46149: PHPUnit 8.x support
--------------------------------------+-----------------------
Reporter: SergeyBiryukov | Owner: netweb
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.6
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-----------------------
Comment (by jrf):
Before I forget to mention it: the "WP version bump" commit does not
''**have**'' to be included in the commits for this ticket, however, as
the patches for this ticket require to stop ''testing'' against PHP < 7.1,
it seemed like a logical commit to include.
----
After this ticket has been addressed, I would like to suggest follow-up
tickets to address the following additional points in the test suite:
* Review any `@requires` and `version_compare()`'s et al in the test suite
to see if any of these can be removed now the requirements have changed.
* Review any disabled tests (like commented out tests) to see if they were
disabled due to version requirements not being met.
* Review if the `includes/phpunit6/compat.php` file can be removed
completely.
Similarly, after the version bump patch has been committed, follow-up
tickets should be opened for the following additional points:
* Removing the random_compat library. This library is no longer needed
when the minimum PHP requirement is PHP 7.1. (Similar to #46799 for the
PHP < 5.6 drop)
* Go through the `compat.php` file to see if there are other PHP polyfills
which can be removed. (Similar to #47698 for the PHP < 5.6 drop)
* Go through the code base to review any code using `version_compare()`,
`function_exists()`, `defined()`, `extension_loaded()` et al to verify
whether these kind of toggles are still needed and remove them whenever
possible. (Similar to #48074 for the PHP < 5.6 drop)
* Updating external PHP dependencies if an update was so far blocked by a
minimum PHP version mismatch.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46149#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list