[wp-trac] [WordPress Trac] #40188: Filter button should not appear when no comments are available in list

[WordPress Trac]

#40188: Filter button should not appear when no comments are available in list
-------------------------------------------------+-------------------------
 Reporter:  swissspidy                           |       Owner:  Jim_Panse
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests commit      |     Focuses:  ui,
  dev-reviewed                                   |  administration
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 [48722] caused unit test failures:
 {{{
 There were 2 failures:

 1)
 Tests_Admin_includesListTable::test_filter_button_should_be_shown_if_there_are_comments
 Failed asserting that '<div class="alignleft actions"></div>' contains "id
 ="post-query-submit"".

 /var/www/tests/phpunit/tests/admin/includesListTable.php:316

 2)
 Tests_Admin_includesListTable::test_filter_comment_status_dropdown_should_be_shown_if_there_are_comments
 Failed asserting that '<div class="alignleft actions"></div>' contains "id
 ="filter-by-comment-type"".

 /var/www/tests/phpunit/tests/admin/includesListTable.php:338
 }}}

 Reverting for now, let's clean this up in #50815.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40188#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform