[wp-trac] [WordPress Trac] #40188: Filter button should not appear when no comments are available in list
WordPress Trac
noreply at wordpress.org
Tue Aug 4 15:55:41 UTC 2020
#40188: Filter button should not appear when no comments are available in list
-------------------------------------------------+-------------------------
Reporter: swissspidy | Owner: Jim_Panse
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 5.5
Component: Comments | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch has-unit-tests commit | Focuses: ui,
dev-feedback | administration
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):
* status: reopened => closed
* resolution: => fixed
Comment:
In [changeset:"48722" 48722]:
{{{
#!CommitTicketReference repository="" revision="48722"
Comments: Use the existing static variable instead of calling
`::has_items()` again in `WP_Comments_List_Table::extra_tablenav()`.
Additionally, removed unnecessary `esc_html()` on the Filter button label.
Core translations are considered safe, and this label is not escaped in
any other instance.
Props whyisjake, SergeyBiryukov.
Fixes #40188.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40188#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list